git: Replace Stalling error for git implementation

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
fluxcd · Nov 11, 2022 · bdcf708 · bdcf708
1 parent 331fd64
commit bdcf708
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/controllers/gitrepository_controller.go b/controllers/gitrepository_controller.go
@@ -768,8 +768,7 @@ func (r *GitRepositoryReconciler) gitCheckout(ctx context.Context,
 		err = fmt.Errorf("invalid Git implementation: %s", gitImplementation)
 	}
 	if err != nil {
-		// Do not return err as recovery without changes is impossible.
-		e := serror.NewStalling(
+		e := serror.NewGeneric(
 			fmt.Errorf("failed to create Git client for implementation '%s': %w", gitImplementation, err),
 			sourcev1.GitOperationFailedReason,
 		)