Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0005: introduction of Digest and change of Revision format #1001

Merged
merged 17 commits into from
Feb 14, 2023

Commits on Feb 10, 2023

  1. api: introduce Digest field to Artifact

    As discussed in RFC-0005, this introduces a `Digest` field to the
    `Artifact` in favor of the now deprecated `Checksum`.
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    964b2d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. storage: calculate Digest for Artifact

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6e0a6f1 View commit details
    Browse the repository at this point in the history
  2. reconcilers: include artifact digest in event meta

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a72badf View commit details
    Browse the repository at this point in the history
  3. digest: register SHA1 digest algorithm

    This algorithm is used by Git commit SHAs, and opens up the digest API
    to work with these references.
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f4eae19 View commit details
    Browse the repository at this point in the history
  4. controllers: use digest for Bucket revision

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    83b6fdc View commit details
    Browse the repository at this point in the history
  5. controllers: use RFC-0005 format for Git revision

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fe8bc43 View commit details
    Browse the repository at this point in the history
  6. controllers: make HelmChart compat with RFC-0005

    This ensures the revision is correctly parsed for `Bucket` and
    `GitRepository` sources from which a chart is built, either in the
    legacy or new RFC-0005 format.
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b89b049 View commit details
    Browse the repository at this point in the history
  7. helm: use digest lib for checksum calculation

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    909ece4 View commit details
    Browse the repository at this point in the history
  8. controllers: make OCIRepository compat with RFC-0005

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    469c938 View commit details
    Browse the repository at this point in the history
  9. api: introduce TransformLegacyRevision helper

    This allows consumers to better handle the transition to the new
    RFC-0005 format ("/" -> "@" separation).
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    eaa4a4f View commit details
    Browse the repository at this point in the history
  10. controllers: use TransformLegacyRevision helper

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f00aeae View commit details
    Browse the repository at this point in the history
  11. controllers: RFC-0005 fmt for HelmRepository rev

    This includes changes to the `ChartRepository`, to allow calculating
    the revision and digest and tidy things.
    
    In addition, the responsibility of caching the `IndexFile` has been
    moved to the reconcilers. As this allowed to remove a lot of
    complexities within the `ChartRepository`, and prevented passing on
    the cache in general.
    
    Change `HelmRepository`'s Revision to digest
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0aaeeee View commit details
    Browse the repository at this point in the history
  12. Allow config using --artifact-digest-algo

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ccad359 View commit details
    Browse the repository at this point in the history
  13. spec: show RFC-0005 format and digest in examples

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    eb4a38e View commit details
    Browse the repository at this point in the history
  14. misc: order imports and align digest aliases

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d62f4dc View commit details
    Browse the repository at this point in the history
  15. Use Artifact.Path for HelmRepository index cache

    Resolving it to a local path does not make it more unique, while
    resulting in longer keys and a lot of safejoin calls.
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f53bfd1 View commit details
    Browse the repository at this point in the history
  16. Use MetaDigestKey from event API

    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9283894 View commit details
    Browse the repository at this point in the history