-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about sourceignore recursion #1007
Conversation
28bbc1d
to
9956e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An OCIRepository
also looks for ignore files:
ps, err := sourceignore.LoadIgnorePatterns(dir, ignoreDomain) |
It looks like whenever |
It also looks like the and may overrule the [`.sourceignore` file exclusions](#sourceignore-file)` I'll add some text and make it aligned with the other docs. |
cd11ebd
to
3b4ab58
Compare
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
3b4ab58
to
106f8ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kingdonb 🙇
https://github.com/fluxcd/pkg/blob/main/sourceignore/sourceignore.go#L114
With references: https://cloud-native.slack.com/archives/CLAJ40HV3/p1674742375696939?thread_ts=1674741099.305269&cid=CLAJ40HV3
Today we advised a user who was looking for another way to tell Flux to ignore a file in Git, and we found this fact about the recursion was not documented. I thought this was a common expectation, but I didn't want to reassure someone that it would work without testing to be sure, or a direct reference to that effect, so @stefanprodan found it for us 👍
Let's add a note about this to the docs, to save the trouble next time.