Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise absolute reference in Artifact for GitRepository name ref #1036

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

aryan9600
Copy link
Member

Use commit.AbsoluteReference() to show the full reference when .spec.ref.name is provided. For eg: refs/heads/main@sha1:<SHA>.

@aryan9600 aryan9600 force-pushed the absolute-ref branch 3 times, most recently from 261445a to d763a18 Compare February 24, 2023 07:17
@aryan9600
Copy link
Member Author

will tag github.com/fluxcdpkg/git and github.com/fluxcd/pkg/git/gogit and update this PR to use that tag after an approval

@hiddeco hiddeco added enhancement New feature or request area/git Git related issues and pull requests labels Mar 2, 2023
Use `commit.AbsoluteReference()` to show the full reference when
`.spec.ref.name` is provided. For eg: `refs/heads/main@sha1:<SHA>`.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@hiddeco hiddeco mentioned this pull request Mar 2, 2023
@hiddeco hiddeco changed the title use absolute refs when ref name is provided Advertise absolute reference in Artifact for GitRepository name ref Mar 2, 2023
@hiddeco hiddeco merged commit b4c4a26 into fluxcd:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants