-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Azure Workload Identity #1048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PS. This is on hold un till we merge the v1 APIs
Given the complexity of documenting this on a second look, we need either need to release this while adding writing extensive documentation for it to the backlog, or leave it out for now. |
a59c980
to
e4d70f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding this would also require changes for HelmRepository and OCIRepository?
efd0d21
to
2749046
Compare
7905f60
to
67c0f67
Compare
With an update to github.com/fluxcd/pkg/oci v0.22.0. This includes a pin of `github.com/docker/docker` to `v20.10.x`, to prevent Oras from complaining. Co-authored-by: Hidde Beydals <hidde@hhh.computer> Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Co-authored-by: Hidde Beydals <hidde@hhh.computer> Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
This PR adds support for Azure Workload Identity for OCIRepositories, Buckets and HelmRepositories when using
provider: azure
.Complemnets: fluxcd/image-reflector-controller#363
Part of: fluxcd/flux2#3041