Store Helm indexes in JSON format #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jul 25, 2023
somtochiama
force-pushed
the
helm-index-json
branch
from
4b64dd5 to
e4eb660
Compare
hiddeco
reviewed
Jul 26, 2023
hiddeco
reviewed
Jul 26, 2023
hiddeco
added
enhancement
9 tasks
hiddeco
changed the title
|
Tested this change against two scenarios:
In both scenarios, memory improvements could be observed but the most significant ones were observed during scenario 2 (as can be expected based on the changes. Scenario 1Before
After
Scenario 2Before
After
|
hiddeco
reviewed
Aug 2, 2023
|
Improvement for scenario 2 is actually much better, as the memory consumption got suppressed by throttling of CPU. Actual consumption (while still running into CPU throttling) is more like this:
|
somtochiama
force-pushed
the
helm-index-json
branch
from
0d40af7 to
b9d8673
Compare
hiddeco
reviewed
Aug 2, 2023
| } | ||
| ] | ||
| } | ||
| } |
hiddeco
reviewed
Aug 2, 2023
Comment on lines
479
to
480
| // `sigs.k8s.io/yaml` package to unmarshal the YAML data. | ||
| // Copied from https://github.com/helm/helm/blob/2544aa23a33977d91fe8f59d12dd923dc43be6c5/pkg/repo/index.go#L378-L390 |
There was a problem hiding this comment.
Suggested change
| // `sigs.k8s.io/yaml` package to unmarshal the YAML data. | |
| // Copied from https://github.com/helm/helm/blob/2544aa23a33977d91fe8f59d12dd923dc43be6c5/pkg/repo/index.go#L378-L390 | |
| // `sigs.k8s.io/yaml` package to unmarshal the YAML data. | |
| // | |
| // Can potentially be replaced when Helm PR for JSON support has been merged. | |
| // xref: https://github.com/helm/helm/pull/12245 |
darkowlzz
reviewed
Aug 2, 2023
hiddeco
reviewed
Aug 3, 2023
| @@ -401,6 +402,15 @@ func (r *ChartRepository) Digest(algorithm digest.Algorithm) digest.Digest { | |||
| return r.digests[algorithm] | |||
| } | |||
|
|
|||
| // ToJSON returns the index formatted as JSON | |||
There was a problem hiding this comment.
Suggested change
| // ToJSON returns the index formatted as JSON | |
| // ToJSON returns the index formatted as JSON. |
|
@somtochiama can you please squash your commits? |
somtochiama
force-pushed
the
helm-index-json
branch
from
184e38d to
8edffe6
Compare
hiddeco
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
LGTM, but would prefer another +1 before this gets merged.
Thank you @somtochiama 🙇 🥇
hiddeco
force-pushed
the
helm-index-json
branch
from
8edffe6 to
74aa43f
Compare
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
hiddeco
force-pushed
the
helm-index-json
branch
from
74aa43f to
1aa9cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1172
Store helm indexes in JSON format for more efficient caching.
See linked issue above for more details.