Sanitize URLs for bucket fetch error messages #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
sanitze-bucker-errors
branch
from
ffaed4b to
c564e7a
Compare
Co-authored-by: Jagpreet Singh Tamber <jagpreetstamber@gmail.com> Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
sanitze-bucker-errors
branch
from
c564e7a to
5854dbe
Compare
souleb
approved these changes
Apr 4, 2024
stefanprodan
added
area/bucket
|
Successfully created backport PR for |
Merged
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Bucket object's URL query strings from logged error messages as the query strings can contain sensitive information.
Thanks to @jagpreetstamber 🏅
Supersedes #1429