Bind cached helm index to the maximum index size #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
added
bug
souleb
changed the title
souleb
force-pushed
the
fix-1451
branch
2 times, most recently
from
3ab3e36
to
c369e75
Compare
Signed-off-by: Soule BA <bah.soule@gmail.com>
stefanprodan
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1451
If implemented, the new behavior is to only cache helm indexes that are under the maximum allowed size. If greater, an error is returned and the reconciliation fails. This avoid accepting big helm indexes that won't be allowed in memory later down the reconciliation process.