-
Notifications
You must be signed in to change notification settings - Fork 203
Promote OCIRepository API to v1 (GA) #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
d4bf1cb
to
fe0b8ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove deprecated things or would this require v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably remove this line too? I don't see the same for v1beta1:
Line 118 in e253855
$(GEN_CRD_API_REFERENCE_DOCS) -api-dir=./api/v1beta2 -config=./hack/api-docs/config.json -template-dir=./hack/api-docs/template -out-file=./docs/api/v1beta2/source.md |
And missed a bump here:
apiVersion: source.toolkit.fluxcd.io/v1beta2 |
LGTM after that!
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
30d6085
to
aa9027e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This PR promotes the OCIRepository kind from v1beta2 to v1 (GA). The v1 API is backwards compatible with v1beta2.