Skip to content

Promote OCIRepository API to v1 (GA) #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

stefanprodan
Copy link
Member

This PR promotes the OCIRepository kind from v1beta2 to v1 (GA). The v1 API is backwards compatible with v1beta2.

@stefanprodan stefanprodan requested a review from a team May 7, 2025 19:38
@stefanprodan stefanprodan added the area/oci OCI related issues and pull requests label May 7, 2025
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove deprecated things or would this require v2?

Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove this line too? I don't see the same for v1beta1:

$(GEN_CRD_API_REFERENCE_DOCS) -api-dir=./api/v1beta2 -config=./hack/api-docs/config.json -template-dir=./hack/api-docs/template -out-file=./docs/api/v1beta2/source.md

And missed a bump here:

apiVersion: source.toolkit.fluxcd.io/v1beta2

LGTM after that!

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants