Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Git packages to implementations #270

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Rename Git packages to implementations #270

merged 2 commits into from
Feb 8, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Jan 28, 2021

This should probably be put on hold till the next MINOR release.

@hiddeco hiddeco marked this pull request as draft January 28, 2021 11:30
@stefanprodan
Copy link
Member

I propose we name the packages after the gitImplementation, libgit2 instead git2go.

@hiddeco hiddeco force-pushed the rename-git-pkgs branch 3 times, most recently from 9f5a915 to 491cabe Compare February 8, 2021 10:39
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco marked this pull request as ready for review February 8, 2021 13:05
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit 568b284 into main Feb 8, 2021
@hiddeco hiddeco deleted the rename-git-pkgs branch February 8, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants