libgit2: use provided host to validate public key #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
libgit2-hostkey
branch
from
9b1e939
to
c00fa60
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
libgit2-hostkey
branch
5 times, most recently
from
4fd0d86
to
f4730cb
Compare
phillebaba
reviewed
Feb 10, 2021
hiddeco
force-pushed
the
libgit2-hostkey
branch
from
f4730cb
to
8c967f2
Compare
hiddeco
added
bug
squaremo
reviewed
Feb 10, 2021
hiddeco
force-pushed
the
libgit2-hostkey
branch
3 times, most recently
from
37cdbc4
to
31efe5c
Compare
squaremo
dismissed
phillebaba’s stale review
We discovered further changes are needed, after the review
squaremo
reviewed
Feb 11, 2021
hiddeco
force-pushed
the
libgit2-hostkey
branch
2 times, most recently
from
e25476b
to
70fdfb5
Compare
squaremo
reviewed
Feb 11, 2021
The callback from libgit2 only provides a hostname (without the port), but the `known_hosts` file indexes the public keys based on the full host (e.g. `[localhost]:123` for a host behind a specific port). As a result, it was unable to find the correct public key for the hostname when it was added to the `known_hosts` file with the port. To work around this, we add the user provided host that includes the port to the `PublicKeyAuth` strategy, and use this to find the right entry in the `known_hosts` file, after having validated that the hostname provided to the callback matches the hostname of the host provided by the user. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
libgit2-hostkey
branch
from
70fdfb5
to
b2f6639
Compare
squaremo
approved these changes
Feb 11, 2021
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback from libgit2 only provides a hostname (without the port),
but the
known_hostsfile indexes the public keys based on the fullhost (e.g.
[localhost]:123for a host behind a specific port).As a result, it was unable to find the correct public key for the
hostname when it was added to the
known_hostsfile with the port.To work around this, we add the user provided host that includes the
port to the
PublicKeyAuthstrategy, and use this to find the rightentry in the
known_hostsfile, after having validated that thehostname provided to the callback matches the hostname of the host
provided by the user.
Fixes: #287