Add shortName to gitrepositories

[abhi-kapoor]

Adding gr as a shortName, similar to how kustomizations has ks:
https://github.com/fluxcd/kustomize-controller/blob/2f2812636448cd27ddc5b4a8af1a333cbebf89ce/config/crd/bases/kustomize.toolkit.fluxcd.io_kustomizations.yaml#L17

Not sure if this is the only change required for this, but would love to know if I am missing something.

[hiddeco]

Our CRDs are dynamically generated and do not allow direct modifications, instead, metadata should be added to the API code as done here: https://github.com/fluxcd/kustomize-controller/blob/2f2812636448cd27ddc5b4a8af1a333cbebf89ce/api/v1beta1/kustomization_types.go#L327

After making this modification, you can run make manifests api-docs to regenerate all the magic ✨ things.

[abhi-kapoor]

Our CRDs are dynamically generated and do not allow direct modifications, instead, metadata should be added to the API code as done here: https://github.com/fluxcd/kustomize-controller/blob/2f2812636448cd27ddc5b4a8af1a333cbebf89ce/api/v1beta1/kustomization_types.go#L327

Ah gotcha, that makes sense, thank you 👍

After making this modification, you can run make manifests api-docs to regenerate all the magic ✨ things.

I will give this a shot 💯

[hiddeco]

Small correction, the right make targets are make generate manifests api-docs (or simply make test).

[abhi-kapoor]

Small correction, the right make targets are make generate manifests api-docs (or simply make test).

Thank you, that seemed to have done the magic 🎆 🧙‍♂️

@hiddeco Just for my own curiosity, adding metadata as comment to the API code and running the make modifies the base YAML CRD under the hood? Or, am I missing something? Thanks

[hiddeco]

Can you please rebase instead of merging changes in, and smash your commits (as it is a small change)?

[abhi-kapoor]

Can you please rebase instead of merging changes in, and smash your commits (as it is a small change)?

@hiddeco Done 👍

[abhi-kapoor]

@hiddeco Can you please let me know if you would like me to do anything additional or are we good to merge?

[hiddeco]

This looks OK, it just needs a rebase. Thanks @abhinav454 🌻

[abhi-kapoor]

This looks OK, it just needs a rebase. Thanks @abhinav454 🌻

Done, thank you so much for your help with this @hiddeco 💯 😄