Switch to crypto/ssh for parsing of private keys
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somtochiama
changed the title
hiddeco
reviewed
Apr 14, 2021
hiddeco
approved these changes
Apr 15, 2021
|
What does this PR do? By the looks of it, this is not just adding a test but a new feature? |
|
No, it improves the previously added feature in #338 to support more key formats. |
hiddeco
changed the title
crypto/ssh for parsing of private keys
|
Thanks, I missed the previous PR. |
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
private-keyy-passwd
branch
from
87e9e47
to
ee43942
Compare
stefanprodan
approved these changes
Apr 19, 2021
3 tasks
pjbgf
pushed a commit
to pjbgf/source-controller
that referenced
this pull request
Jul 31, 2022
Use of MUSL was a temporary solution to mitigate cross-platform issues while building openssl and libssh2. Since Unmanaged transport has been deprecated, openssl and libssh2 dependencies are no longer required and by extension MUSL. Enables libgit2 threadless support and provides a regression assurance for image-automation-controller/fluxcd#339. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key was generated with
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com