Write chart data on identitical values overwrite #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
bug
hiddeco
force-pushed
the
empty-chart-fix
branch
from
716e2e8
to
2d8ce4c
Compare
stefanprodan
approved these changes
Apr 21, 2021
This likely happened because the byte buffer response was already being read by the chart loader, making it empty by the time the artifact was written to storage. As an alternative, and because it makes the code a tiny bit less obnoxious: write the data to a temp file first, and later decide what file to copy over and use as an stored artifact. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
empty-chart-fix
branch
from
2d8ce4c
to
917300d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely happened because the byte buffer response was already
being read by the chart loader, making it empty by the time the
artifact was written to storage.
As an alternative, and because it makes the code a tiny bit less
obnoxious: write the data to a temp file first, and later decide
what file to copy over and use as an stored artifact.
Fixes: #343