Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ignore domain for GitRepository rules #351

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Apr 23, 2021

Unlike Bucket resources which are matched by key as presented by S3,
ignore rules for GitRepository objects do have a domain: the temporary
directory of the Git repository.

Fixes: #350

Unlike Bucket resources which are matched by key as presented by S3,
ignore rules for GitRepository objects do have a domain: the temporary
directory of the Git repository.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco added the bug Something isn't working label Apr 23, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco

@hiddeco hiddeco merged commit a6f3458 into main Apr 23, 2021
@hiddeco hiddeco deleted the fix-ignore-domain-gitrepo branch April 23, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source controller fails to correctly fetch the git repositories
2 participants