-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Debian instead of Alpine for multi-arch builds #386
Conversation
14248d0
to
3f287d9
Compare
binutils-gold
for ARMv7 target
Test image: |
I am testing with a Debian install on armhf (armv7l kernel)
also uname -a
|
@kingdonb can you run the following:
and share output for the two container commands? |
Doesn't get quite that far:
Working on upgrades that may help with this (the Docker version and everything else is probably at least a year old)
|
As |
67e0a67
to
fcc806d
Compare
Better shape now:
I was using the baked-in |
@kingdonb can you do the same on an ARM64 machine and post here please. |
This commit changes the base image for the build and controller container images to Debian slim. Reason for this is that it has proven to be hard to produce working executables for AMD64, ARM64 and ARMv7 at all times using Alpine, due to them being dynamically linked and compiled using CGO, and Alpine having constraints like musl that create an extra barrier, especially in combination with our exotic set of dependency constraints. There are a number of trade-offs we have to live with by doing this, not limited to: * An increased build time, the full release pipeline used to take 25-35 minutes, based on the images we have build for testing purposes this seems to have become 35-40 minutes. * An increased image size of roughly two times the (compressed) size of the Alpine based image. Signed-off-by: Hidde Beydals <hello@hidde.co>
|
Same as last time (but much faster) |
fcc806d
to
7e6b88e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #385
This PR changes the base image for the build and controller
container images to Debian slim.
Reason for this is that it has proven to be hard to produce working
executables for AMD64, ARM64 and ARMv7 at all times using Alpine,
due to them being dynamically linked and compiled using CGO, and
Alpine having constraints like musl that create an extra barrier,
especially in combination with our exotic set of dependency
constraints.
There are a number of trade-offs we have to live with by doing this,
not limited to:
minutes, based on the images we have build for testing purposes this
seems to have become 35-40 minutes.
the Alpine based image.