Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-envtest in Makefile #404

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Commits on Jul 30, 2021

  1. Add setup-envtest in Makefile

    Use setup-envtest for installing the binaries required for using
    envtest.
    The latest envtest binaries for k8s v1.21.2 are not compatible with
    kubebuilder < v3, which results in envtest suite test tear down
    failure. envtest fails to stop the kube-apiserver.
    
    ```
    timeout waiting for process kube-apiserver to stop
    ```
    
    Pin to k8s v1.19.2 envtest binaries that work with kubebuilder v2.
    
    Signed-off-by: Sunny <darkowlzz@protonmail.com>
    darkowlzz committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    4ce7c0d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. workflows/e2e: Use fluxcd/pkg/actions/envtest

    Use fluxcd/pkg/actions/envtest to setup envtest.
    
    Since the run-test action runs in a container, the host $PATH is not
    passed to the test container. The ENV directive in actions/run-tests
    Dockerfile is used to append the PATH with envtest binary path. This
    helps avoid redownload of the envtest binaries when it's not found in
    the path via the Makefile targets.
    
    Signed-off-by: Sunny <darkowlzz@protonmail.com>
    darkowlzz committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    cb3fb3b View commit details
    Browse the repository at this point in the history