Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite HelmRepositoryReconciler to new standards #413

Merged
merged 1 commit into from
Aug 12, 2021

Commits on Aug 12, 2021

  1. Rewrite HelmRepositoryReconciler to new standards

    This commit rewrites the `HelmRepositoryReconciler` to new standards,
    while implementing the newly introduced Condition types, and trying to
    adhere better to Kubernetes API conventions.
    
    More specifically it introduces:
    
    - Implementation of more explicit Condition types to highlight
      abnormalities.
    - Extensive usage of the `conditions` subpackage from `runtime`.
    - Better and more conflict-resilient (status)patching of reconciled
      objects using the `patch` subpackage from runtime.
    - Proper implementation of kstatus' `Reconciling` and `Stalled`
      conditions.
    - Refactoring of some Helm elements to make them easier to use within
      the new reconciler logic.
    - Integration tests that solely rely on `testenv` and do not
      use Ginkgo.
    
    There are a couple of TODOs marked in-code, these are suggestions for
    the future and should be non-blocking.
    In addition to the TODOs, more complex and/or edge-case test scenarios
    may be added as well.
    
    Signed-off-by: Hidde Beydals <hello@hidde.co>
    hiddeco committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    4963963 View commit details
    Browse the repository at this point in the history