Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: check GitRepository reference != nil #49

Merged
merged 1 commit into from
Apr 29, 2020
Merged

controllers: check GitRepository reference != nil #49

merged 1 commit into from
Apr 29, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Apr 29, 2020

To prevent the reconciler from panicing when no reference is configured for the GitRepository.

@hiddeco
controllers: check GitRepository reference != nil
2c0b175 
To prevent the reconciler from panicing when no reference is
configured for the GitRepository.
@hiddeco hiddeco added the bug Something isn't working label Apr 29, 2020
stefanprodan
stefanprodan approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hiddeco hiddeco merged commit f2bff90 into master Apr 29, 2020
@hiddeco hiddeco deleted the gitrepository-panic branch April 29, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan