Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bucket JSONPath from URL to endpoint #514

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

jonathan-innis
Copy link
Contributor

JSON printer column path for Bucket type is currently wrong and doesn't print correctly. Path should be changed to spec.endpoint

@jonathan-innis jonathan-innis force-pushed the change-bucket-jsonpath branch 2 times, most recently from bb5dd90 to 13b6611 Compare December 4, 2021 23:15
Signed-off-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
@stefanprodan stefanprodan added the area/bucket Bucket related issues and pull requests label Dec 5, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jonathan-innis

@stefanprodan stefanprodan merged commit cfa72ad into fluxcd:main Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants