Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file close operation to not use defer and add test case for CopyFromPath #538

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Update file close operation to not use defer and add test case for CopyFromPath #538

merged 2 commits into from
Jan 12, 2022

Conversation

tomhuang12
Copy link
Contributor

This is to address issue described in fluxcd/pkg#174.

Signed-off-by: Tom Huang tom.huang@weave.works

@tomhuang12
Update file close operation to not use defer and add test case for Co…
8868d39 
…pyFromPath

Signed-off-by: Tom Huang <tom.huang@weave.works>
pjbgf
pjbgf requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suggesting one small change on the code and a nit around the tests.

controllers/storage.go Outdated Show resolved Hide resolved
controllers/storage_test.go Outdated Show resolved Hide resolved
@tomhuang12
proper file close operation based on feedback
5bb4283 
Signed-off-by: Tom Huang <tom.huang@weave.works>
pjbgf
pjbgf approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stefanprodan
stefanprodan approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomhuang12

@stefanprodan stefanprodan added the area/storage Storage related issues and pull requests label Jan 12, 2022
@stefanprodan stefanprodan merged commit d2eec33 into fluxcd:main Jan 12, 2022
@tomhuang12 tomhuang12 deleted the fix-defer-close branch January 12, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/storage Storage related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhuang12 @stefanprodan @pjbgf