Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Permissions to github Workflows #551

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Add Permissions to github Workflows #551

merged 1 commit into from
Jan 20, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Jan 20, 2022

Improve GITHUB_TOKEN permissions in the workflows.

Signed-off-by: Soule BA soule@weave.works

@pjbgf pjbgf mentioned this pull request Jan 20, 2022
Open
pjbgf
pjbgf approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@souleb nice one! From my side it is a LGTM.

We would just need to keep an eye for the cron job after merged to ensure there were no problems.

@souleb souleb added the area/ci CI related issues and pull requests label Jan 20, 2022
@stefanprodan
Copy link
Member

@souleb please rebase

@souleb
Add Permissions to github Workflows
53fa1f9 
Imrove GITHUB_TOKEN permissions in the workflows.

Signed-off-by: Soule BA <soule@weave.works>
@souleb souleb force-pushed the token-permissions branch from dde86b3 to 53fa1f9 Compare January 20, 2022 17:01
@stefanprodan stefanprodan merged commit e1655b6 into fluxcd:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@souleb @stefanprodan @pjbgf