Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default timeout to 60s #570

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Increase default timeout to 60s #570

merged 1 commit into from
Feb 7, 2022

Conversation

stefanprodan
Copy link
Member

Increase the default timeout from 20s to 60s for Git repository cloning and Bucket download. Given that libgit2 is 3x times slower than go-git, we need to increase the timeout to avoid SSH could not read data: Error waiting on socket errors.

Fix: fluxcd/image-automation-controller#293
Fix: #439

Increase the default timeout from 20s to 60s for Git repository cloning and Bucket download

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added area/git Git related issues and pull requests area/bucket Bucket related issues and pull requests labels Feb 7, 2022
@stefanprodan stefanprodan requested a review from hiddeco February 7, 2022 08:30
@stefanprodan stefanprodan merged commit 5aec67b into main Feb 7, 2022
@stefanprodan stefanprodan deleted the default-timeout branch February 7, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests area/git Git related issues and pull requests
Projects
None yet
2 participants