Reuse transport for Helm downloads #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
bug
|
Initial tests on source controller shows that the behaviour is still the same. After 20 minutes running: ghcr.io/fluxcd/source-controller:v0.21.2 this version To fix #578 we will have to manage the transport lifecycle and send it across to the helm getter. |
pjbgf
force-pushed
the
helm-getter-http-transport
branch
3 times, most recently
from
ec93675
to
822c860
Compare
|
The last patch seem to have resolved it. |
pjbgf
force-pushed
the
helm-getter-http-transport
branch
3 times, most recently
from
b47d573
to
260637b
Compare
hiddeco
commented
Mar 2, 2022
hiddeco
changed the title
This commit updates to a version of Helm 3.8.0, with patches applied to deal with memory leak and HTTP transport issues. The latter being described in #578. Signed-off-by: Hidde Beydals <hello@hidde.co>
Reuses the same transport across different helm chart downloads, whilst resetting the tlsconfig to avoid cross-contamination. Crypto material is now only processed in-memory and does not touch the disk. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
helm-getter-http-transport
branch
from
632545d
to
f63681f
Compare
|
This looks good to me, great work @pjbgf 🙇 Blocked by GitHub to stamp it as I initialized the PR, but someone else can probably work the magic. |
stefanprodan
reviewed
Mar 2, 2022
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
helm-getter-http-transport
branch
from
bb816d9
to
7d61553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates to a version of Helm 3.8.0, with patches applied to
deal with memory leak and HTTP transport issues. The latter being
described in #578.
Potentially fixes #578