Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental managed transport for libgit2 operations #606

Merged
merged 8 commits into from
Mar 16, 2022
Merged

Experimental managed transport for libgit2 operations #606

merged 8 commits into from
Mar 16, 2022

Commits on Mar 16, 2022

  1. Implement Managed Transport for libgit2 

    libgit2 network operations are blocking and do not provide timeout nor context capabilities,
leading for several reports by users of the controllers hanging indefinitely.

By using managed transport, golang primitives such as http.Transport and net.Dial can be used
to ensure timeouts are enforced.

Co-Authored-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    aa32881 View commit details
    Browse the repository at this point in the history

  2. Add tests for experimental libgit2 transport 

    Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a000d8b View commit details
    Browse the repository at this point in the history

  3. Add license headers 

    Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    24bc95e View commit details
    Browse the repository at this point in the history

  4. Optimise basic auth for libgit2 managed transport 

    The initial implementation was based off upstream, which cause
an initial request to fail, and only then the credentials would
be added into the request.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    4ed54bc View commit details
    Browse the repository at this point in the history

  5. Fix word casing 

    Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    822788b View commit details
    Browse the repository at this point in the history

  6. Fix race condition on httpSmartSubTransport 

    Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d1a7e5d View commit details
    Browse the repository at this point in the history

  7. Enforce effective URL on error messages 

    Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    43661dd View commit details
    Browse the repository at this point in the history

  8. Support redirects for libgit2 managed transport 

    For backwards compatibility, support for HTTP redirection is enabled when targeting
the same host, and no TLS downgrade took place.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @darkowlzz
    Paulo Gomes authored and darkowlzz committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    115040e View commit details
    Browse the repository at this point in the history