build: enable -race for go test
#615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
go-test-race
branch
6 times, most recently
from
7ec1ac5
to
faeb4ed
Compare
pjbgf
force-pushed
the
go-test-race
branch
3 times, most recently
from
f58f794
to
a828e91
Compare
|
Not being able to reproduce the building issues on arm64, on Mac nor Linux. This may just be the runner misbehaving. |
Signed-off-by: Hidde Beydals <hello@hidde.co>
The variable used to store the information about proxied request was being written to in the proxy server request handler and read for assertion at the end of the test. Replace the boolean variable with an atomic counter to count the number of requests proxied, preventing the race condition. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Since the transport reuse is dependent on the garbage collection, the result is inconsistent. It fails frequently when running the tests with the go race detector. Remove the test. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Co-authored-by: Sunny <darkowlzz@protonmail.com> Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
|
The latest commit disables race detection on arm64 only, as our runners seem not to like it very much. |
Race detection is not working properly in our arm64 runners. It has been tested against both M1 and linux arm64 machines and in both cases the results were aligned with the other platforms. By disabling this we can ensure race detection is being enforced on the other platforms, and we can later review this position. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
approved these changes
Jun 14, 2022
stefanprodan
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.