Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate positive polarity conditions for ArtifactInStorage #646

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Separate positive polarity conditions for ArtifactInStorage #646

merged 4 commits into from
Mar 30, 2022

Commits on Mar 30, 2022

  1. Introduce separate positive polarity conditions 

    Introduce separate positive polarity conditions which are used to set
Ready condition. Move the "artifact stored" ready condition into
ArtifactInStorage positive polarity condition. If ArtifactInStorage is
True and there's no negative polarity condition present, the Ready
condition is summarized with ArtifactInStorage condition value.

Also, update the priorities of the conditions. ArtifactInStorage has
higher priority than SourceVerfied condition. If both are present, the
Ready condition will have ArtifactInStorage.
The negative polarity conditions are reordered to have the most likely
actual cause of failure condition the highest priority, for example
StorageOperationFailed, followed by the conditions that are reconciled
first in the whole reconciliation so as to prioritize the first failure
which may be the cause of subsequent failures.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    d939e98 View commit details
    Browse the repository at this point in the history

  2. Update all reconcilers with ArtifactInStorage cond 

    Update alll the other reconcilers similar to the GitRepository
reconcilers to introduce positive condition ArtifactInStorage and
reorder the status conditions.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    86860ec View commit details
    Browse the repository at this point in the history

  3. controllers: emit event and log source up-to-date 

    Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b41c717 View commit details
    Browse the repository at this point in the history

  4. Update docs with new conditions and events 

    Signed-off-by: Sunny <darkowlzz@protonmail.com>
    @darkowlzz
    darkowlzz committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b869716 View commit details
    Browse the repository at this point in the history