Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes empty credentials from Basic Auth #648

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Removes empty credentials from Basic Auth #648

merged 2 commits into from
Mar 30, 2022

Commits on Mar 30, 2022

  1. Fixes regression accessing GitLab public repositories 

    Some git servers are more accommodating than others. Gitlab will try to
validate credentials when they are provided, even if they are empty and
the target repository is public, leading to a failed authentication error.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @hiddeco
    Paulo Gomes authored and hiddeco committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    c841790 View commit details
    Browse the repository at this point in the history

  2. Improve documentation on Debugging source controller 

    Expands on the current documentation to help contributors debug the controller
regardless of all its existing dependencies.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
    @hiddeco
    Paulo Gomes authored and hiddeco committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    da91e47 View commit details
    Browse the repository at this point in the history