Add flag to allow configuration of SSH kex algos #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
preferred-kex
branch
3 times, most recently
from
28039dc to
e7cf79c
Compare
pjbgf
reviewed
Apr 5, 2022
main.go
Outdated
| @@ -120,6 +122,8 @@ func main() { | |||
| "The TTL of an index in the cache. Valid time units are ns, us (or µs), ms, s, m, h.") | |||
| flag.StringVar(&helmCachePurgeInterval, "helm-cache-purge-interval", "1m", | |||
| "The interval at which the cache is purged. Valid time units are ns, us (or µs), ms, s, m, h.") | |||
| flag.StringSliceVar(&kexAlgos, "ssh-kex-algos", []string{}, | |||
| "The list of kex algorithms to use for ssh arranged from most preferred to least.") | |||
There was a problem hiding this comment.
Suggested change
| "The list of kex algorithms to use for ssh arranged from most preferred to least.") | |
| "The list of key exchange algorithms to use for ssh connections, arranged from most preferred to the least.") |
pjbgf
approved these changes
Apr 6, 2022
Adds a flag `ssh-kex-algos` which configures the gogit and libgit2 managed clients to use the specified list of kex algos for ssh. If not used the default list in `golang/x/crypto/ssh` is used. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
hiddeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a runtime flag to specify which key exchange algorithms to use for ssh.
Ref: fluxcd/flux2#2610
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com