Resolve index out of range when running locally #670
Conversation
main.go
Outdated
| svcParts := strings.Split(os.Getenv("HOSTNAME"), "-") | ||
| return fmt.Sprintf("%s.%s", | ||
| strings.Join(svcParts[:len(svcParts)-2], "-"), os.Getenv("RUNTIME_NAMESPACE")) | ||
| } | ||
|
|
There was a problem hiding this comment.
@EdwinWalela thanks for the quick turn around. Can you please remove the extra line and sign-off the commit to ensure it passes the DCO check?
You can signoff the current commit with git commit --amend --signoff and then just need to push it back up.
More info on DCO checks:
https://wiki.linuxfoundation.org/dco#:~:text=The%20DCO%20is%20a%20per,org%2F%20for%20that%20particular%20contribution.
|
@pjbgf Thanks for the feedback. I've signed off on the latest commit. Let me know if there is more I should do. |
|
@EdwinWalela do you mind squashing both commits into one please? I have noticed that the second commit message has two |
EdwinWalela
force-pushed
the
edwin-dev
branch
2 times, most recently
from
b45ec17
to
88db86d
Compare
|
@pjbgf I have squashed the previous commits and signed it off with |
|
@EdwinWalela Your branch current have 4 commits, you can drop the last 2 by resetting the state back to the second commit:
You can then squash the two commits by rebasing interactively:
You will be shown a list of the commits prefixed with "pick", change the second commit's prefix to "s" or "squash". Save and exit ( |
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works> Resolve index out of range when running locally Signed-off-by: edwinwalela <edwinwalela@gmail.com>
|
@pjbgf Thanks for the help, I noticed I did a mistake on renaming the sign off. I'll open a new PR instead. |
This seeks to close #668.
Removed the
ifblock so thatstorageAddris used, preventing the controller from panicking ifRUNTIME_NAMESPACEis non-empty and doesn't contain hyphens