Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix flakiness of git related tests #686

Merged
merged 2 commits into from
Apr 25, 2022
Merged

tests: Fix flakiness of git related tests #686

merged 2 commits into from
Apr 25, 2022

Commits on Apr 25, 2022

  1. tests: Set GIT_CONFIG_GLOBAL=/dev/null for tests run via make test 

    This ensures that no host specific git configuration is pulled in while
testing. One such example would be "init.defaultBranch" which is set to
"main" on some hosts, which then causes tests to fail as they keep looking
for "master" branches.

Signed-off-by: Alexander Block <ablock84@gmail.com>
    @codablock
    codablock committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    7c8b175 View commit details
    Browse the repository at this point in the history

  2. tests: Use proper timeouts in gitrepository and helmrepository tests 

    I assume using "interval" for timeouts was an accident and "timeout" was
actually meant to be used. This also fixes flakiness of tests.

Signed-off-by: Alexander Block <ablock84@gmail.com>
    @codablock
    codablock committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    fa09aa2 View commit details
    Browse the repository at this point in the history