gitrepo: set conditions in gitCheckout #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we have more test flakes https://github.com/fluxcd/source-controller/runs/6623628981?check_suite_focus=true#step:5:446. |
darkowlzz
reviewed
May 27, 2022
| @@ -744,9 +745,10 @@ func (r *GitRepositoryReconciler) gitCheckout(ctx context.Context, | |||
| authOpts.TransportOptionsURL = fmt.Sprintf("ssh://%s/%s/%d", obj.Name, obj.UID, obj.Generation) | |||
| } else { | |||
| e := &serror.Stalling{ | |||
| Err: fmt.Errorf("git repository URL has invalid transport type: '%s'", obj.Spec.URL), | |||
| Err: fmt.Errorf("git repository URL '%s' has invalid transport type, expected to be one of http, https, ssh", obj.Spec.URL), | |||
There was a problem hiding this comment.
Maybe we should say "supported protocols", instead of expected?
Thinking in terms of what the user would see.
There was a problem hiding this comment.
Currently the CLI does something similar:
✗ git URL scheme 'stl' not supported, can be: ssh, http and https
darkowlzz
approved these changes
May 27, 2022
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
improve-managed
branch
from
d70962f
to
613ccc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com
Refer: #727 (comment)