Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: Pass ctx to all the transport opts #743

Merged
merged 1 commit into from
May 29, 2022

Conversation

darkowlzz
Copy link
Contributor

The context passed to Checkout() has a timeout. Pass it forward to
the transport in the option for all the checkouts.

Missed in #740

The context passed to Checkout() has a timeout. Pass it forward to
the transport in the option for all the checkouts.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz added the area/git Git related issues and pull requests label May 28, 2022
@pjbgf pjbgf added this to the GA milestone May 29, 2022
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @darkowlzz.

LGTM

@stefanprodan stefanprodan merged commit 36bbaf0 into main May 29, 2022
@stefanprodan stefanprodan deleted the libgit2-transport-opt-ctx branch May 29, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants