Add docs on managed identity for Azure Blob #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jun 2, 2022
docs/spec/v1beta2/buckets.md
Outdated
Comment on lines
450
to
452
| Create an `AzureIdentity` object that references the identity created above: | ||
| ```yaml |
There was a problem hiding this comment.
Suggested change
| Create an `AzureIdentity` object that references the identity created above: | |
| ```yaml | |
| Create an `AzureIdentity` object that references the identity created above: | |
docs/spec/v1beta2/buckets.md
Outdated
Comment on lines
464
to
467
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | ||
| ```yaml |
There was a problem hiding this comment.
Suggested change
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | |
| ```yaml | |
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | |
| ```yaml |
Suggested change
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | |
| ```yaml | |
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created: | |
| ```yaml |
docs/spec/v1beta2/buckets.md
Outdated
| type: 0 # user-managed identity | ||
| ``` | ||
|
|
||
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. |
There was a problem hiding this comment.
Suggested change
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | |
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created: | |
docs/spec/v1beta2/buckets.md
Outdated
| type: 0 # user-managed identity | ||
| ``` | ||
|
|
||
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. |
There was a problem hiding this comment.
Suggested change
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created. | |
| Create an `AzureIdentityBinding` object that binds pods with a specific selector with the `AzureIdentity` created: | |
docs/spec/v1beta2/buckets.md
Outdated
| selector: ${IDENTITY_NAME} | ||
| ``` | ||
|
|
||
| Label the source-controller correctly so that it can match an identity binding. |
There was a problem hiding this comment.
Suggested change
| Label the source-controller correctly so that it can match an identity binding. | |
| Label the source-controller correctly so that it can match an identity binding: |
docs/spec/v1beta2/buckets.md
Outdated
| selector: ${IDENTITY_NAME} | ||
| ``` | ||
|
|
||
| Label the source-controller correctly so that it can match an identity binding. |
There was a problem hiding this comment.
Suggested change
| Label the source-controller correctly so that it can match an identity binding. | |
| Label the source-controller correctly so that it can match an identity binding: |
docs/spec/v1beta2/buckets.md
Outdated
| aadpodidbinding: ${IDENTITY_NAME} # match the AzureIdentity name | ||
| ``` | ||
|
|
||
| Then you don't need to reference a secret |
There was a problem hiding this comment.
What does "then" refer to? "Now"?
There was a problem hiding this comment.
It refers to when you have aad-pod-identity set up and you have created the identities and labeled the SC pod
docs/spec/v1beta2/buckets.md
Outdated
| aadpodidbinding: ${IDENTITY_NAME} # match the AzureIdentity name | ||
| ``` | ||
|
|
||
| Then you don't need to reference a secret |
There was a problem hiding this comment.
What does "then" refer to? "Now"?
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
azure-blob-doc
branch
from
5b76c23 to
bb7aa14
Compare
stefanprodan
approved these changes
Jun 3, 2022
stefanprodan
added
area/docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: website/961
This documentation is mostly on accessing Azure Blob using managed identities and aad-pod-identity
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com