Fix repository cache regression #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
added
bug
darkowlzz
reviewed
Jun 6, 2022
| @@ -186,7 +186,6 @@ func (b *remoteChartBuilder) downloadFromRepository(remote *repository.ChartRepo | |||
| err = fmt.Errorf("could not load repository index for remote chart reference: %w", err) | |||
| return nil, &BuildError{Reason: ErrChartPull, Err: err} | |||
| } | |||
| defer remote.Unload() | |||
There was a problem hiding this comment.
With the removal of Unload(), my recommendation in https://github.com/fluxcd/source-controller/pull/690/files#r878152484 becomes more feasible.
There was a problem hiding this comment.
Yes 👍 I am taking your recommendation into account in the coming PR that enable dependencies from OCI Helm Repositories.
darkowlzz
reviewed
Jun 6, 2022
If implemented this make sure we don't unload an index before caching it during a chart build phase. Signed-off-by: Soule BA <soule@weave.works>
souleb
force-pushed
the
fix-cache-regression
branch
from
6581b7a
to
0d4d78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduce in #690. We no longer cache Helm repository indexes when cache is enabled because of a defer function in the
remote builderwhich unload the index.If implemented this make sure we don't unload an index before caching it during a chart build phase. The index is unloaded downstream after successfully caching it.
Signed-off-by: Soule BA soule@weave.works