libgit2: refactor tests to use managed and unmanaged transport cleanly #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
requested review from
pjbgf and
darkowlzz
and removed request for
pjbgf
darkowlzz
reviewed
Jun 9, 2022
darkowlzz
added
area/git
darkowlzz
reviewed
Jun 9, 2022
|
Could you also rebase? The branch is out-of-date. |
pjbgf
reviewed
Jun 9, 2022
Refactors libgit2 checkout tests to test managed and unmanaged transport by making sure the tests requiring unmanaged transport are run before, any tests that require managed transport (since disabling managed transport isn't possible). This is done via arranging the tests carefully in alphabetically sorted names, i.e. the tests with unmanaged transport go in `checkout_test.go`, which forces golang to run the tests in that file before any other tests. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
|
It would be good to check the Managed Transport state to confirm that each test is being assessed against the correct state (initialised or not). |
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors libgit2 checkout tests to test managed and unmanaged
transport by making sure the tests requiring unmanaged transport are run
before, any tests that require managed transport (since disabling
managed transport isn't possible). This is done via arranging the tests
carefully in alphabetically sorted names, i.e. the tests with unmanaged
transport go in
checkout_test.go, which forces golang to run the testsin that file before any other tests.
Follow-up to #727, related to #745 and branched off from #746 (to avoid increasing complexity and the size of the PR)
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com