Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm-oci] disable cache in oci registry client #799

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[helm-oci] disable cache in oci registry client #799

merged 1 commit into from
Jun 29, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Jun 28, 2022 •
edited by stefanprodan
Loading

fixes #787

If implemented, the oci registry client is created with cache disabled.

Depends on: helm/helm#11086

Signed-off-by: Soule BA soule@weave.works

@souleb souleb marked this pull request as draft June 28, 2022 06:58
@souleb souleb added area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Jun 28, 2022
@souleb souleb changed the title disable cache in oci registry client [Helm]disable cache in oci registry client Jun 28, 2022
@souleb souleb mentioned this pull request Jun 28, 2022
Closed
@hiddeco hiddeco changed the title [Helm]disable cache in oci registry client [Helm] disable cache in oci registry client Jun 28, 2022
@hiddeco hiddeco changed the title [Helm] disable cache in oci registry client [helm-oci] disable cache in oci registry client Jun 28, 2022
@souleb
Copy link
Member Author

souleb commented Jun 28, 2022

github.com/fluxcd/pkg/helmtestserver has to be downgraded to v0.7.2 to work. Otherwise we need to update it first I think.

@souleb souleb marked this pull request as ready for review June 28, 2022 20:15
darkowlzz
darkowlzz reviewed Jun 29, 2022
View reviewed changes
go.mod Show resolved Hide resolved
stefanprodan
stefanprodan reviewed Jun 29, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

@souleb can you rebase please.

@souleb
disable cache in oci registry client
988fd1f 
If implemented, the oci registry client is created with cache disabled.

Signed-off-by: Soule BA <soule@weave.works>
darkowlzz
darkowlzz approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stefanprodan
stefanprodan approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🥇

@stefanprodan stefanprodan merged commit 5356f72 into fluxcd:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[helm-oci] ECR auth expires
3 participants
@souleb @darkowlzz @stefanprodan