Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgit2 to v1.3.2 #834

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Update libgit2 to v1.3.2 #834

merged 2 commits into from
Jul 15, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jul 14, 2022

Updates golang-with-libgit2-all to v0.1.2 which contains libgit2-1.3.2.

Relates to fluxcd/golang-with-libgit2#33.

Testing image: ghcr.io/fluxcd/source-controller:rc-b4345783.

@pjbgf pjbgf marked this pull request as ready for review July 14, 2022 09:54
@pjbgf pjbgf added area/git Git related issues and pull requests area/ci CI related issues and pull requests labels Jul 14, 2022
@pjbgf
Copy link
Member Author

pjbgf commented Jul 14, 2022

This should be a low impact change (based on the upstream commits). Tested it with a wide range of repositories and worked as expected:
image

Updates golang-with-libgit2-all to v0.1.2 which contains libgit2-1.3.2.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf force-pushed the libgit2-1.3.2 branch 7 times, most recently from 4b1f28a to 5aa5043 Compare July 14, 2022 17:49
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf force-pushed the libgit2-1.3.2 branch 3 times, most recently from 2f85553 to 9c21f8a Compare July 15, 2022 07:09
@pjbgf
Copy link
Member Author

pjbgf commented Jul 15, 2022

Changing KUBEBUILDER_CONTROLPLANE_STOP_TIMEOUT does not seem to take effect within the CI to increase the envtest stop timeout, so will merge as is and follow-up on a separate PR.

Running locally on MacOS 12 there was a consistent error due to the change on error message returned (x509: “example.com” certificate is not standards compliant) on macOS 12, which was fixed with 9c21f8a.

@pjbgf pjbgf merged commit 8cff49f into main Jul 15, 2022
@pjbgf pjbgf deleted the libgit2-1.3.2 branch July 15, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests area/git Git related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants