libgit2: upgrade to golang-with-libgit2 v0.1.4 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
from
54140a2 to
8005dae
Compare
|
The new TAG needs to be changed in 2 other places: |
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
2 times, most recently
from
2b21d3b to
f42e430
Compare
|
We need to update the fuzzer logic to use the libgit2-only binary: https://github.com/fluxcd/source-controller/blob/main/tests/fuzz/oss_fuzz_build.sh#L31 |
pjbgf
requested changes
Jul 22, 2022
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
3 times, most recently
from
2d1e524 to
b1f741b
Compare
hiddeco
reviewed
Jul 25, 2022
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
3 times, most recently
from
e3cbb2a to
5e3a2ee
Compare
hiddeco
approved these changes
Jul 26, 2022
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
from
5e3a2ee to
f489805
Compare
pjbgf
reviewed
Jul 26, 2022
pjbgf
reviewed
Jul 26, 2022
Comment on lines
93
to
96
| go-fuzz -tags gofuzz -func="${function}" -o "${fuzzer}.a" . | ||
| ${CXX} ${CXXFLAGS} ${LIB_FUZZING_ENGINE} -o "${OUT}/${fuzzer}" \ | ||
| "${fuzzer}.a" \ | ||
| "${TARGET_DIR}/lib/libgit2.a" "${TARGET_DIR}/lib/libssh2.a" \ | ||
| "${TARGET_DIR}/lib/libz.a" "${TARGET_DIR}/lib64/libssl.a" \ | ||
| "${TARGET_DIR}/lib64/libcrypto.a" \ | ||
| "${fuzzer}.a" "${TARGET_DIR}/lib/libgit2.a" \ | ||
| -fsanitize="${SANITIZER}" |
There was a problem hiding this comment.
By the byte, now we don't need to embed the entire dependency chain, we may be able to revert back to the Vanilla tooling from the CIFuzz. Let's revisit this in a future/separate PR.
Upgrade to golang-with-libgit2 v0.1.4 and use libgit2 which is compiled without being linked to libssh2 and openssl. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
remove-unmanaged-transport
branch
from
f489805 to
bd37bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to golang-with-libgit2 v0.1.4 and use libgit2 which is compiled
without being linked to libssh2 and openssl.
Relates to: #782
Fixes: #762
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com