[OCIRepository] Add support for non-TLS insecure container registries #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
reviewed
Aug 31, 2022
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
approved these changes
Aug 31, 2022
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optinal field named
insecureto the OCIRepository API. Withspec.insecurewe allow Flux to work with in-cluster container registries such as Kubernetes Kind Docker registry. This will enable users to run Flux locally for dev/testing without the need to connect their local clusters to a registry SaaS or setup TLS with self-signed certs.PS. In the future, the insecure flags will be subject to #806 so that cluster admin could disable this behaviour on production environments.