Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with Go 1.19 #920

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Build with Go 1.19 #920

merged 1 commit into from
Sep 28, 2022

Conversation

stefanprodan
Copy link
Member

Changes:

  • Update Go to 1.19 in CI
  • Use Go 1.19 in base image
  • Update controller-gen v0.8.0 (v0.7 fails with Go 1.19) and regenerate manifests

@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Sep 28, 2022
@stefanprodan
Build with Go 1.19
ca3496e 
- Update Go to 1.19 in CI
- Use Go 1.19 in base image
- Update controller-gen v0.8.0 and regenerate manifests

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
pjbgf
pjbgf approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit ac80849 into main Sep 28, 2022
@stefanprodan stefanprodan deleted the build-go1.19 branch September 28, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @pjbgf