Remove libgit2 and git2go from codebase #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
force-pushed
the
remove-libgit2
branch
2 times, most recently
from
f41e264
to
422e64f
Compare
|
Can you please mark this field as deprecated and no longer used please https://github.com/fluxcd/source-controller/blob/main/api/v1beta2/gitrepository_types.go#L98 |
pjbgf
force-pushed
the
remove-libgit2
branch
from
01da54d
to
61a0a6d
Compare
darkowlzz
reviewed
Dec 12, 2022
darkowlzz
reviewed
Dec 12, 2022
pjbgf
force-pushed
the
remove-libgit2
branch
from
61a0a6d
to
d551277
Compare
darkowlzz
reviewed
Dec 12, 2022
.dockerignore
Outdated
| @@ -1 +1 @@ | |||
| build/libgit2/ | |||
| build/ | |||
There was a problem hiding this comment.
Let's have a newline here like before.
|
and source-controller/hack/ci/e2e.sh Line 145 in aad4060 |
pjbgf
force-pushed
the
remove-libgit2
branch
from
d551277
to
32323e7
Compare
added 6 commits
December 12, 2022 15:34
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
remove-libgit2
branch
from
32323e7
to
cc75764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
libgit2implementation which was deprecated in v0.32.0,resulting in a smaller code base and more streamlined build process.
Test image:
ghcr.io/fluxcd/source-controller:rc-8005af8b.Things of note:
Breaking changes:
ForceGoGitImplementationhas been deprecated and removed.