Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to docsy as Hugo module #1136

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Move to docsy as Hugo module #1136

merged 1 commit into from
Oct 19, 2022

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Sep 7, 2022

Fixes: #889

Signed-off-by: Daniel Holbach daniel@weave.works

@stefanprodan
Copy link
Member

@dholbach this broke the tabs https://deploy-preview-1136--fluxcd.netlify.app/flux/installation/

@dholbach
Copy link
Member Author

dholbach commented Sep 7, 2022

@dholbach this broke the tabs https://deploy-preview-1136--fluxcd.netlify.app/flux/installation/

Well-spotted! I pulled in an older version of docsy in go.mod - I updated it to the latest and greatest now.

@dholbach
Copy link
Member Author

dholbach commented Sep 7, 2022

@kingdonb Pinging you as I'm not sure if it'll need changes to the Dockerfile - I personally don't use it for developing.

@stefanprodan
Copy link
Member

Now I see lots of errors in the console around web fonts

@dholbach
Copy link
Member Author

dholbach commented Sep 7, 2022

I let upstream know about the issue and updated Font-Awesome to what it needs to be (they need to update their respective go.mod).

@dholbach dholbach marked this pull request as draft September 7, 2022 10:35
@dholbach
Copy link
Member Author

dholbach commented Sep 7, 2022

It works locally, but not on Netlify. I'll move this to draft mode for now.

@kingdonb
Copy link
Member

kingdonb commented Sep 8, 2022

I'll take a look at the Dockerfile thing later this week and make sure it's still functioning 👍

@dholbach dholbach marked this pull request as ready for review October 16, 2022 12:33
@dholbach
Copy link
Member Author

It's working now! 🎉

@dholbach dholbach added the meta label Oct 17, 2022
Move to docsy as Hugo module
8a911be 
Fixes: #889

Signed-off-by: Daniel Holbach <daniel@weave.works>
stefanprodan
stefanprodan approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @dholbach 🏅

@dholbach dholbach merged commit 0034f4a into fluxcd:main Oct 19, 2022
@dholbach dholbach deleted the fix-889 branch October 19, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@kingdonb kingdonb Awaiting requested review from kingdonb

@Arhell Arhell Awaiting requested review from Arhell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Docsy as Hugo Module?
3 participants
@dholbach @stefanprodan @kingdonb