GA: Publish v1 docs for GitRepository, Receiver & Kustomization #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
force-pushed
the
rcv-v1
branch
5 times, most recently
from
818be4e
to
d068deb
Compare
|
It looks great! Thanks @makkes I've put this on hold until we release NC, then you can switch back to semver in the script. |
stefanprodan
changed the title
makkes
changed the title
makkes
pushed a commit
to fluxcd/notification-controller
that referenced
this pull request
Mar 30, 2023
This commit bumps the Receiver API version to v1 in preparation of the Flux GitOps GA milestone (https://fluxcd.io/roadmap/#flux-gitops-ga-q1-2023). We are now actively maintaining two versions of the notification API group in parallel: v1 which currently only holds the Receiver kind and v1beta2 for all other kinds. Since we haven't run into this situation before, I had to change the way we expose the API docs in ./docs/api: The directory now has sub-directories for each active API version. Therefore we need to change our scripts in the website repository to take this change into account so that we expose both API group version at https://fluxcd.io/flux/components/notification/api/. This change is implemented in fluxcd/website#1427. refs #436 Signed-off-by: Max Jonas Werner <mail@makk.es>
alekspog
pushed a commit
to alekspog/notification-controller
that referenced
this pull request
Mar 30, 2023
This commit bumps the Receiver API version to v1 in preparation of the Flux GitOps GA milestone (https://fluxcd.io/roadmap/#flux-gitops-ga-q1-2023). We are now actively maintaining two versions of the notification API group in parallel: v1 which currently only holds the Receiver kind and v1beta2 for all other kinds. Since we haven't run into this situation before, I had to change the way we expose the API docs in ./docs/api: The directory now has sub-directories for each active API version. Therefore we need to change our scripts in the website repository to take this change into account so that we expose both API group version at https://fluxcd.io/flux/components/notification/api/. This change is implemented in fluxcd/website#1427. refs fluxcd#436 Signed-off-by: Max Jonas Werner <mail@makk.es>
15 tasks
makkes
pushed a commit
that referenced
this pull request
Apr 3, 2023
We changed the directory structure of the specs in the respective controllers' v1 versions. Until a full Flux release has been cut we need to exclude all v1 versions from being imported until #1427 has landed. Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes
force-pushed
the
rcv-v1
branch
3 times, most recently
from
c0db154
to
819539d
Compare
added 4 commits
April 5, 2023 14:12
The following API types have been graduated to v1: - NC Receiver - KC Kustomization - SC GitRepository In addition to that we want the API navigation entries to appear at the bottom of the tree. To accomplish that the import script is now able to parse a weight parameter from imported markdown specs and put it into the front matter of the resulting file. refs fluxcd/notification-controller#436 Signed-off-by: Max Jonas Werner <mail@makk.es>
- GitRepository v1 - Kustomization v1 - Receiver v1 - CronJob v1 Signed-off-by: Max Jonas Werner <mail@makk.es>
Signed-off-by: Max Jonas Werner <mail@makk.es>
refs fluxcd/flux2#3731 Signed-off-by: Max Jonas Werner <mail@makk.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
weightcomments for proper ordering of pages