Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom metrics guide #1610

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add custom metrics guide #1610

merged 1 commit into from
Aug 18, 2023

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Aug 7, 2023

This documents how kube-state-metrics can be used to configure custom flux metrics.

The guide has references to the configurations in https://github.com/fluxcd/flux2-monitoring-example that exist in fluxcd/flux2-monitoring-example#1.

Preview: https://deploy-preview-1610--fluxcd.netlify.app/flux/monitoring/custom-metrics/

@darkowlzz darkowlzz added area/docs Documentation related issues and pull requests area/flux Flux related issues and pull requests labels Aug 7, 2023
@makkes
Copy link
Member

makkes commented Aug 9, 2023

@darkowlzz does this apply to version 2.0 of Flux as well? If yes, please add the backport label.

@darkowlzz
Copy link
Contributor Author

does this apply to version 2.0 of Flux as well? If yes, please add the backport label.

@makkes it's not specific to any flux version. It's an entirely new generic thing and depends on the monitoring stack deployment. I'm not sure if it needs to be backported. The monitoring with prometheus guide will also need to be updated and backported along with this.

@makkes
Copy link
Member

makkes commented Aug 10, 2023

I'm fine with anything here, just want to note that if we don't backport it it will not be available at the 2.0 Flux docs as soon as we release 2.1.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz changed the base branch from main to monitoring-v2 August 17, 2023 22:34
@stefanprodan stefanprodan merged commit e29f934 into monitoring-v2 Aug 18, 2023
@stefanprodan stefanprodan deleted the custom-metrics branch August 18, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests area/flux Flux related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants