Add events page #13
Add events page #13
Conversation
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
jpellizzari
force-pushed
the
show-events
branch
from
a14ff2b to
4907fff
Compare
Not sure what's going on with that. That is what the API response returns. |
I understand, but in that case should the column be titled 'Reason' or something else like 'Type'? |
|
This needs to be normalized from our point (as in: the controllers that emit the events) to meet the K8s standards, see: fluxcd/pkg#56 (comment) |
There is another field called "type", and the "Reason" field is returning those "LeaderElection" values. I think @hiddeco 's comment speaks to that discrepancy |
Is there something I need to change in this PR? |
|
No, nothing to be done here. We need to address this in |
This commit adds support for providing a reason to the Event method, and maps the severity of an event to a K8s core event type. This makes the emitted events in-line with Kubernetes standards, and is beneficial to the Flux UI: fluxcd/webui#13 The reason to not fully depend on the K8s event type and drop the severity is because there have been reports from users wanting to have access to "debug" events, a type not known to Kubernetes. Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit adds support for providing a reason to the Event method, and maps the severity of an event to a K8s core event type. This makes the emitted events in-line with Kubernetes standards, and is beneficial to the Flux UI: fluxcd/webui#13 The reason to not fully depend on the K8s event type and drop the severity is because there have been reports from users wanting to have access to "debug" events, a type not known to Kubernetes. Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit adds support for providing a reason to the Event method, and maps the severity of an event to a K8s core event type. This makes the emitted events in-line with Kubernetes standards, and is beneficial to the Flux UI: fluxcd/webui#13 The reason to not fully depend on the K8s event type and drop the severity is because there have been reports from users wanting to have access to "debug" events, a type not known to Kubernetes. Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit adds support for providing a reason to the Event method, and maps the severity of an event to a K8s core event type. This makes the emitted events in-line with Kubernetes standards, and is beneficial to the Flux UI: fluxcd/webui#13 The reason to not fully depend on the K8s event type and drop the severity is because there have been reports from users wanting to have access to "debug" events, a type not known to Kubernetes. Signed-off-by: Hidde Beydals <hello@hidde.co>
Adds a basic events page to help with troubleshooting.