feat: shortcuts for color setters #1361
Conversation
Add 1, 2, ..., 9 as the shortcuts for the color pickers (at the top of the window).
Turns out that was a really bad idea and you wouldn't be able to type numbers in textboxes.
|
I really wanted that feature for a long time. Thanks for implementing that. But, this shortcut is already used for switching to specific tabs. For example Alt + 3 to go to 3rd tab. |
|
Didn't know that, I feel like it's more frequent to switch colors than to switch tabs, so maybe it's not a bad idea to remap tab switching to Ctrl+Alt+n? |
|
I agree with you that I rarely (probably never) switch tabs with that keyboard shortcut. I just reminded you about the conflict. |
|
Pretty sure the shortcut is not set by rnote but by the use of Adw>TabBar in rnote for having tabs, and I'm not sure it's settable. I'd be somewhat weird to have rnote be the only gtk/adwaita application where the I didn't know the shortcut and I'm not sure it not showing in the keyboard shortcut window is intended behavior (though that's a separate issue altogether) |
|
what about using |
| [ | ||
| [p.setter_1(), p.setter_2(), p.setter_3()], | ||
| [p.setter_4(), p.setter_5(), p.setter_6()], | ||
| [p.setter_7(), p.setter_8(), p.setter_9()], | ||
| ] | ||
| .concat() |
There was a problem hiding this comment.
Not sure if we really need to split the array for aesthetic purposes, but it does look better ;)
There was a problem hiding this comment.
I mean I could revert it but… it looks nice so :3
Co-authored-by: Moritz Mechelk <moritzmechelk@gmail.com>
|
Could you please run the formatter again? It seems like that small change made the line too long, which is why the CI is failing :/ |
|
I was thinking if there was still the possibility of adding a shortcut to make the fill or stroke transparent. This would help us save one of the colors. Boxes without background and with background are usually used and right now there is no easy way to do it. |
Add
<Alt>1,<Alt>2, ...,<Alt>9as the shortcuts for the color pickers (at the top ofthe window).