Add option to compile all gems #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I thought I had invited you as a collaborator previously, but apparently I invited antiscool (lowercase). I've sent a new invite. Feel free to merge this change. |
Move from the features section to the configuration section
|
@rubys Thanks. I have just moved the documentation in the README from the features section to the configuration section. (It feels more like configuration than a feature). I will merge it after the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-compiled version of nokogiri for ARM requires a newer version of glibc than the ruby docker images come with. This can be worked around by not using the pre-compiled versions and instead compiling all gems.
This can be done with the bundle configuration
bundle config set force_ruby_platform true