build(package): use npmignore instead of files field #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfantone
requested review from
crash7,
ivelazco and
gaston-flores
and removed request for
a team
|
➿ Code coverage
|
nfantone
commented
Oct 7, 2020
| "lint": "eslint index.js src/", | ||
| "prettier": "prettier --write src/ index.js", | ||
| "test": "jest --env=node --colors --bail --detectOpenHandles --errorOnDeprecated --noStackTrace src/", | ||
| "test.coverage": "run-s test --coverage --coverageDirectory .coverage", | ||
| "test.watch": "run-s test --watchAll", | ||
| "generate-docs": "jsdoc -c jsdoc.json" | ||
| "test.watch": "run-s test --watchAll" |
There was a problem hiding this comment.
No actual changes here: just key sorting on package.json.
crash7
approved these changes
Oct 7, 2020
| @@ -22,50 +22,68 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "author": "Flybondi <dev@flybondi.com> (https://flybondi.com)", | |||
| "sideEffects": false, | |||
There was a problem hiding this comment.
gold plating? is this related with #16?
There was a problem hiding this comment.
It is. Harmless for now.
|
@crash7 Regardless, test files are definitely being included in the tarball today. ❯ tree node_modules/@flybondi/ramda-land
node_modules/@flybondi/ramda-land
├── CHANGELOG.md
├── LICENSE
├── README.md
├── index.js
├── package.json
└── src
├── all-to-lower-upper.js
├── all-to-lower-upper.test.js
├── always-new.js
├── always-new.test.js
# ... |
nfantone
changed the title
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.npmignorerules are ignored byyarnif also defining a"files"fields inpackage.json. This made*.test.jsfiles be included in the final package onpublishorpack, while also generating inconsistent packages if usingyarnvs.npm."sideEffects": falsetopackage.json.