Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with option with 0-arity function #63

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix with option with 0-arity function #63

merged 1 commit into from
Apr 12, 2023

Conversation

skydread1
Copy link
Contributor

Closes #52

Add a check on arity of the args of the function provided to the :with option and handle the case of 0-arity function (failing with :tuple)

@skydread1 skydread1 temporarily deployed to deploy April 12, 2023 08:22 — with GitHub Actions Inactive
robertluo
robertluo approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@robertluo robertluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@robertluo robertluo merged commit 550f499 into flybot-sg:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertluo robertluo robertluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no way to validate nested maps in case of type fn
2 participants
@skydread1 @robertluo